-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(backport) src/doc: improve man page and --help #10730
Conversation
@@ -117,6 +117,15 @@ Print a stack trace whenever synchronous I/O is detected after the first turn | |||
of the event loop. | |||
|
|||
.TP | |||
.BR \-\-trace\-events\-enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have this flag on v7.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, missed to remove these here, will fix.
Enables the collection of trace event tracing information. | ||
|
||
.TP | ||
.BR \-\-trace\-event\-categories " " \fIcategories\fR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have this flag either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh! you're right! good catch
- add missing environment variables to --help - add missing flags to man page - sort environment variables alphabetically - add some highlighting to the man page - remove stops from descriptions in --help for consistency - few other minor tweaks to --help PR-URL: nodejs#10157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
2cf822d
to
ee62961
Compare
Fixed, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
||
.TP | ||
.BR NODE_DISABLE_COLORS=1 | ||
When set to 1 colors will not be used in the REPL. | ||
.BR NODE_EXTRA_CA_CERTS =\fIfile\fR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has this actually landed in v7 yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in v7.x-staging
at least:
Line 4539 in e07b651
if (const char* extra = secure_getenv("NODE_EXTRA_CA_CERTS")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in v7.x
branch.
Landed on |
Backport of #10157 to
v7.x-staging
. cc: @evanlucas